Repository navigation
deps: setup-node 7, login-action 4, and dependabot/script hygiene - #98
Merged
Merged
Conversation
Takes over two Dependabot PRs that kept conflicting as main moved (#97, #94) and folds in three fixes that came out of merging the rest of the batch. Action bumps: - actions/setup-node 6.4.0 -> 7.0.0 (both ci.yml jobs) - docker/login-action 3.7.0 -> 4.6.0 (release.yml) Version-comment drift Dependabot leaves behind: upload-sarif shared the v4 SHA with init/analyze but was still labelled v3, and one checkout SHA carried both '# v7' and '# v7.0.1'. TypeScript is now ignored for minor+major. @angular/build 22 declares peer typescript '>=6.0 <6.1', so 7.x fails npm ci with ERESOLVE (#91) -- and so would 6.1. TypeScript here follows Angular, so it should move with an Angular major, not on its own. 6.0.x patches still flow. refresh-lockfiles.ps1 fixes, both found by running it: - It hardcoded the SDK digest, which #87 had already made stale. It now reads the digest out of the Dockerfile, so that drift can't recur. - Windows PowerShell 5.1 wraps native stderr in ErrorRecords, so with ErrorActionPreference=Stop docker's 'Unable to find image ... locally' pull message killed the script on any machine without the image cached -- i.e. on first use, by the people most likely to need it. Natives now run through a helper that relaxes the preference and judges by exit code.
This was referenced Aug 31, 2026
thomas-lg
added a commit
that referenced
this pull request
Sep 13, 2026
Takes over two Dependabot PRs that kept conflicting as main moved (#97, #94) and folds in three fixes that came out of merging the rest of the batch. Action bumps: - actions/setup-node 6.4.0 -> 7.0.0 (both ci.yml jobs) - docker/login-action 3.7.0 -> 4.6.0 (release.yml) Version-comment drift Dependabot leaves behind: upload-sarif shared the v4 SHA with init/analyze but was still labelled v3, and one checkout SHA carried both '# v7' and '# v7.0.1'. TypeScript is now ignored for minor+major. @angular/build 22 declares peer typescript '>=6.0 <6.1', so 7.x fails npm ci with ERESOLVE (#91) -- and so would 6.1. TypeScript here follows Angular, so it should move with an Angular major, not on its own. 6.0.x patches still flow. refresh-lockfiles.ps1 fixes, both found by running it: - It hardcoded the SDK digest, which #87 had already made stale. It now reads the digest out of the Dockerfile, so that drift can't recur. - Windows PowerShell 5.1 wraps native stderr in ErrorRecords, so with ErrorActionPreference=Stop docker's 'Unable to find image ... locally' pull message killed the script on any machine without the image cached -- i.e. on first use, by the people most likely to need it. Natives now run through a helper that relaxes the preference and judges by exit code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes over two Dependabot PRs that kept losing races with a moving
main(#97, #94 — both one-line SHA bumps that re-conflicted after every merge), and folds in three fixes that surfaced while merging the rest of today's batch.Action bumps
actions/setup-node6.4.0 → 7.0.0 (bothci.ymljobs) — takes over deps: bump actions/setup-node from 6.4.0 to 7.0.0 #97docker/login-action3.7.0 → 4.6.0 (release.yml) — takes over deps: bump docker/login-action from 3.7.0 to 4.6.0 #94login-actionisn't exercised by PR CI, only byrelease.yml, which runs onworkflow_runafter CI succeeds onmain. So it gets validated on merge — I'll confirm that run goes green rather than assume it.Version-comment drift
Dependabot updates the SHA but reuses the old comment, so labels had gone stale:
codeql-action/upload-sarifshared the v4 SHA withinit/analyzebut was still labelled# v3.actions/checkoutSHA carried both# v7and# v7.0.1.Both are cosmetic, but the comment is the only human-readable version in a SHA-pinned workflow, so a wrong one actively misleads.
Ignore TypeScript minor + major
@angular/build@22declarespeer typescript ">=6.0 <6.1", so #91 (TS 7) failednpm ciwithERESOLVE— and 6.1 would fail too, not just 7.x. TypeScript here is driven by Angular and should move with an Angular major, not on its own. 6.0.x patches still flow.refresh-lockfiles.ps1— two bugs, both found by running ited034a8toe1ffd2a#87 (dotnet/sdkdigest bump) had already made stale within an hour of the script landing. It now reads the digest out of theDockerfile, so the drift can't recur — the script had a copy of exactly the kind of duplicated pin it exists to protect.ErrorRecord; with$ErrorActionPreference = 'Stop', docker'sUnable to find image ... locallypull message was fatal. That meant the script worked for me (image cached) and failed for anyone running it fresh — the people most likely to need it. Natives now go through a helper that relaxes the preference and judges by exit code.Verified
Exercised all three paths of the script against this branch:
Lock files are consistent with the projects., exit 0.csproj/lock mismatcherror NU1004surfaced, exit 1The third was reproduced by actually editing
Serilog.AspNetCoreback to 9.0.0 inApi.csprojand confirming both the direct and the transitive (Tests→Api) NU1004 appeared — i.e. the exact failure this whole thread started from.